Remove invalid legend tag for w3c validator happiness #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The html legend tag is only valid inside a fieldset tag (http://www.w3.org/TR/html-markup/legend.html). In the-bootstrap, the legend tag was used outside a fieldset to style "Leave a Reply" on the comment form. I added a legend class style to style.css (and style.min.css) and changed functions.php to write a span with the class. The legend tag was also used outside a fieldset to style the "password required" text for a password protected post. I changed functions.php to put the text in a p before the form styled with class post-password-legend and modified style.css (and style.min.css) to replace .post-password-form legend with post-password-legend. According to W3C, the p tag is allowed in forms. ("A form can contain text and markup (paragraphs, lists, etc.) in addition to form controls." in section http://www.w3.org/TR/html401/interact/forms.html#edef-FORM) Tested on localhost and styled to match existing the-bootstrap appearance.
|
Fixed in aa97c02 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This replaces #48 and is more complete.
The html legend tag is only valid inside a fieldset tag (http://www.w3.org/TR/html-markup/legend.html).
In the-bootstrap, the legend tag was used outside a fieldset to style "Leave a Reply" on the comment form. I added a legend class style to style.css (and style.min.css) and changed functions.php to write a span with the class.
The legend tag was also used outside a fieldset to style the "password required" text for a password protected post. I changed functions.php to put the text in a p before (correction as I'm writing the pull: inside) the form styled with class post-password-legend and modified style.css (and style.min.css) to replace .post-password-form legend with post-password-legend. According to W3C, the p tag is allowed in forms. ("A form can contain text and markup (paragraphs, lists, etc.) in addition to form controls." in section http://www.w3.org/TR/html401/interact/forms.html#edef-FORM -- I tried a span but it wouldn't take margin properly.)
Tested on localhost and styled to match existing the-bootstrap appearance.